-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nydusd live-upgrade control flow #249
Conversation
0715819
to
d780579
Compare
Codecov ReportBase: 38.15% // Head: 36.09% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
==========================================
- Coverage 38.15% 36.09% -2.06%
==========================================
Files 28 29 +1
Lines 2026 2194 +168
==========================================
+ Hits 773 792 +19
- Misses 1154 1300 +146
- Partials 99 102 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
/* | ||
* Copyright (c) 2022. Nydus Developers. All rights reserved. | ||
* | ||
* SPDX-License-Identifier: Apache-2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SPDX should be kept in the first line as a thumb rule.
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
We can use it when start upgraded daemon with the awareness of those instances ralated to old one. Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Also make it support replace the nydusd binary path pointing to the newer version and receive --upgrade flag Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
We can do live-upgrade to take over old nydusd fs service by handling http requests Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your review :-) |
Add a control flow of nydusd live-upgrade to the system package.