Add nydusd live-upgrade control flow #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changweige
force-pushed
the
upgrade
branch
3 times, most recently
from
0715819
to
d780579
Compare
Codecov ReportBase: 38.15% // Head: 36.09% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
==========================================
- Coverage 38.15% 36.09% -2.06%
==========================================
Files 28 29 +1
Lines 2026 2194 +168
==========================================
+ Hits 773 792 +19
- Misses 1154 1300 +146
- Partials 99 102 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
hsiangkao
reviewed
Nov 17, 2022
| /* | ||
| * Copyright (c) 2022. Nydus Developers. All rights reserved. | ||
| * | ||
| * SPDX-License-Identifier: Apache-2.0 |
There was a problem hiding this comment.
SPDX should be kept in the first line as a thumb rule.
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
We can use it when start upgraded daemon with the awareness of those instances ralated to old one. Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Also make it support replace the nydusd binary path pointing to the newer version and receive --upgrade flag Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
We can do live-upgrade to take over old nydusd fs service by handling http requests Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
|
Thanks for your review :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a control flow of nydusd live-upgrade to the system package.