Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: github.com/containerd/containerd v1.7.20, switch to github.com/containerd/platforms, github.com/distribution/reference module #610

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jul 31, 2024

go.mod: github.com/containerd/containerd v1.7.20

  • switches to separate github.com/containerd/containerd/api module
  • switches to separate github.com/containerd/platforms module

full diff: containerd/containerd@v1.7.18...v1.7.20

switch to github.com/containerd/platforms module

containerd 1.7.19 and up alias the platforms package to the new module,
and deprecate the package.

switch to github.com/distribution/reference module

containerd 1.7.19 and up alias the reference/docker package to the new module,
and deprecate the package.

@thaJeztah thaJeztah changed the title go.mod: github.com/containerd/containerd v1.7.20, switch to github.com/containerd/platforms module go.mod: github.com/containerd/containerd v1.7.20, switch to github.com/containerd/platforms, github.com/distribution/reference module Jul 31, 2024
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 34.36%. Comparing base (d5701f0) to head (261dd69).
Report is 4 commits behind head on main.

Files Patch % Lines
pkg/auth/keychain.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #610   +/-   ##
=======================================
  Coverage   34.36%   34.36%           
=======================================
  Files          65       65           
  Lines        6606     6606           
=======================================
  Hits         2270     2270           
  Misses       4021     4021           
  Partials      315      315           
Files Coverage Δ
pkg/auth/image_proxy.go 75.43% <ø> (ø)
pkg/remote/remotes/handlers.go 15.22% <ø> (ø)
pkg/stargz/resolver.go 30.95% <100.00%> (ø)
pkg/utils/registry/registry.go 33.33% <100.00%> (ø)
pkg/auth/keychain.go 31.48% <0.00%> (ø)

- switches to separate github.com/containerd/containerd/api module
- switches to separate github.com/containerd/platforms module

full diff: containerd/containerd@v1.7.18...v1.7.20

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
containerd 1.7.19 and up alias the platforms package to the new module,
and deprecate the package.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
containerd 1.7.19 and up alias the reference/docker package to the new module,
and deprecate the package.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah marked this pull request as ready for review August 1, 2024 07:06
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@imeoer imeoer merged commit 15fe071 into containerd:main Aug 1, 2024
16 checks passed
@thaJeztah thaJeztah deleted the containerd_1.7.20 branch August 1, 2024 07:33
This was referenced Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants