add arm64/v9 matching vectors #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow arm64/v9 to fall back to arm64/v8 Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
|
I agree with this change, but it's also significantly more complicated than this (thanks Arm! 😭) -- see golang/go#60905 (comment) 🙈 See also containerd/containerd#10022 and #8 (which is an attempt to more correctly implement the complexity of arm64 variants that I somehow missed previously 😞) |
AkihiroSuda
approved these changes
Oct 20, 2024
|
closing this in favor of #8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow arm64/v9 to fall back to arm64/v8
cc @tianon