Move windows matcher logic so all platforms can use #22
Conversation
cpuguy83
force-pushed
the
windows_everywhere
branch
7 times, most recently
from
39f21d0 to
4dce1e7
Compare
|
And now with CI passing! 🎉 |
| } | ||
| } | ||
|
|
||
| func winRevision(v string) int { |
There was a problem hiding this comment.
Is this an implementation of a subset of the previous function? As is, this might return a value successfully where the above might return something empty, right? (That's kind of surprising behavior and might lead to subtle bugs; maybe it should just call the above function?)
There was a problem hiding this comment.
It is different in that given a string like x.y.z.N it returns N where as the other function only looks at x.y.z
There was a problem hiding this comment.
My worry here is that the other function returns the zero value but this one returns a number (foo.bar.baz.123), but I guess this one isn't really used in complete isolation because that last number is only meaningful if you know the other three are the same in the two values you're comparing.
There was a problem hiding this comment.
Yes, and is only used in the Less function.
cpuguy83
force-pushed
the
windows_everywhere
branch
from
4dce1e7 to
638b515
Compare
cpuguy83
force-pushed
the
windows_everywhere
branch
from
638b515 to
c2347f9
Compare
There shouldn't be any need to make the platform matcher stuff for Windows to only be available on Windows since none of it is dependent on the machine running it. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
windows_everywhere
branch
from
c2347f9 to
7c58292
Compare
There shouldn't be any need to make the platform matcher stuff for Windows to only be available on Windows since none of it is dependent on the machine running it.
Related to moby/buildkit#5614