fix: add a stat condition check for uploading release binaries #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits adds a check to confirm the existance of files in the release subdirectories before attempting to upload to GitHub release. This change helps avoid unnecessary errors in the case where the release subdirectories are empty Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
cpuguy83
approved these changes
Jul 31, 2023
|
Did this still created a source only release? |
|
Yes, for |
jprendes
reviewed
Jul 31, 2023
| done | ||
| else | ||
| echo "No files to upload" | ||
| exit 0 |
There was a problem hiding this comment.
Shouldn't this be exit 1?
There was a problem hiding this comment.
No we have crates that don't have binaries.
Each tag and release is per crate.
ipuustin
reviewed
Aug 1, 2023
| # skip upload if there are no files | ||
| if stat release/*/* >/dev/null 2>&1; then | ||
| for i in release/*/*; do | ||
| gh release upload ${RELEASE_NAME} $i |
There was a problem hiding this comment.
Should have quotes here around the variables:
gh release upload "${RELEASE_NAME}" "$i"
There was a problem hiding this comment.
It would be ideal factor this out as a script and have shellcheck run on all our scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits adds a check to confirm the existance of files in the release subdirectories before attempting to upload to GitHub release. This change helps avoid unnecessary errors in the case where the release subdirectories are empty.
An instance of the failed run this commits tries to resolve is found here.