Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use latest kind and k8s release #356

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

jsturtevant
Copy link
Contributor

Updating to use more recent versions of kubernetes and kind

@jprendes
Copy link
Collaborator

Did kind introduce some breaking changes? 😕

@devigned
Copy link
Contributor

Might be related to: kubernetes-sigs/kind#3064

@jsturtevant
Copy link
Contributor Author

I did reproduce this locally, Looking into it

@jprendes
Copy link
Collaborator

I think the remaining failures are just #347 / #354.

@jsturtevant
Copy link
Contributor Author

the remaining failures are

 create containerd task: failed to start shim: start failed: /usr/local/bin/containerd-shim-wasmer-v1: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /usr/local/bin/containerd-shim-wasmer-v1)\n/usr/local/bin/containerd-shim-wasmer-v1: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /usr/local/bin/containerd-shim-wasmer-v1)\n/usr/local/bin/containerd-shim-wasmer-v1: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /usr/local/bin/containerd-shim-wasmer-v1)\n: exit status 1: unknown"

I believe this is because of the changes in https://github.com/kubernetes-sigs/kind/releases/tag/v0.19.0 from ubuntu to debian

@jsturtevant
Copy link
Contributor Author

@jprendes I am thinking we might be able to use the cross build stuff you've added to correctly link the glibc version?

@jprendes
Copy link
Collaborator

I can try moving CI to use cross tomorrow.

@jsturtevant
Copy link
Contributor Author

leaving notes on the changes for future self:

@jsturtevant
Copy link
Contributor Author

jsturtevant commented Oct 17, 2023

I tried using the docker buildx bake and related scripts but having trouble running them, do we have docs on how they should be run? I took a look at the .github/workflos/release.yaml and using similiar commands but not having luck.

updated error after using correct commands

docker buildx bake bins-cross
....
docker buildx bake bins-cross
[+] Building 0.0s (0/0)
docker-bake.hcl:29
--------------------
  27 |         }
  28 |         args = {
  29 | >>>         "BASE_IMAGE" = "${image}"
  30 |         }
  31 |     }
--------------------
ERROR: docker-bake.hcl:29,27-32: Unknown variable; There is no variable named "image"., and 5 other diagnostic(s)

update again: I needed to upgrade my local docker version and now it is working with:

CRATE=containerd-shim-wasmtime VERSION=test docker buildx bake bins-cross

@jsturtevant
Copy link
Contributor Author

I can try moving CI to use cross tomorrow.

I am also having trouble running these locally since I am using ubuntu. Will need to come up with solution that works locally too.

@jsturtevant
Copy link
Contributor Author

I was able to get the tests passing using the docker build (without the bake stuff) locally using

docker build -o dist/bin/ .
make test/k8s-wasmtime

@jsturtevant
Copy link
Contributor Author

that time it worked, but need to rebase to pick up #354

Mossaka
Mossaka previously approved these changes Oct 18, 2023
Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! But maybe we should wait for #359 to merge first?

@jsturtevant
Copy link
Contributor Author

Yes, I'll rebase on that once it is ready

Copy link
Collaborator

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsturtevant!
LGTM

@Mossaka
Copy link
Member

Mossaka commented Oct 19, 2023

Need a rebase

Signed-off-by: James Sturtevant <jstur@microsoft.com>
Signed-off-by: James Sturtevant <jstur@microsoft.com>
@jsturtevant
Copy link
Contributor Author

Need a rebase

allset!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants