deprecate: remove 'shared' mode #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add details of the removal into the commit message and that we may replace it with a sandboxer implementation? |
Mossaka
force-pushed
the
deprecate-daemon
branch
from
26315d2
to
60696b2
Compare
|
Done. |
cpuguy83
approved these changes
Sep 16, 2024
The 'shared' mode in runwasi is not actively maintained and tested. This commit is removing it. The 'shared' mode will soon be replaced with the Sandboxer API described in containerd#385 Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
Mossaka
force-pushed
the
deprecate-daemon
branch
from
60696b2
to
92421f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#670