Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing condition to stop reaping child procs #151

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

jprendes
Copy link
Contributor

@jprendes jprendes commented Jul 5, 2023

Since PR #75 the loop that reaps child processes is not properly stopping.
Since WaitPidFlag::WNOHANG is being used, the WaitStatus::StillAlive status should also be considered.

StillAlive

There are currently no state changes to report in any awaited child process. This is only returned if WaitPidFlag::WNOHANG was used (otherwise wait() or waitpid() would block until there was something to report).

This is equivalent to the res_pid == 0 condition before PR #75.

Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
@jprendes
Copy link
Contributor Author

jprendes commented Jul 6, 2023

The CI failure seems like an unrelated transient network issue

+ integration
go: google.golang.org/genproto@v0.0.0-20230306155012-7f2fa6fef1f4 requires
	cloud.google.com/go/bigquery@v1.48.0 requires
	github.com/apache/arrow/go/v10@v10.0.1 requires
	lukechampine.com/uint[12](https://github.com/containerd/rust-extensions/actions/runs/5466464185/jobs/9961489697?pr=151#step:7:13)8@v1.2.0: unrecognized import path "lukechampine.com/uint128": https fetch: Get "https://lukechampine.com/uint128?go-get=1": dial tcp [2600:3c03::f03c:91ff:fe55:92ba]:443: connect: network is unreachable
make: *** [Makefile:215: integration] Error 1
Error: Process completed with exit code 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-shim Containerd shim T-bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants