Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rust fmt rules to format imports #97

Merged
merged 2 commits into from
Oct 2, 2022
Merged

Add Rust fmt rules to format imports #97

merged 2 commits into from
Oct 2, 2022

Conversation

mxpv
Copy link
Member

@mxpv mxpv commented Sep 25, 2022

This is a follow up for discussion here: #95 (comment) whether its possible to format imports.
Actually turns out there is a way to enforce it, however the majority of config
items remain unstable, so we have to call cargo fmt with +nightly switch.

See new rustfmt.toml

@Burning1020 WDYT?

Signed-off-by: Maksym Pavlenko pavlenko.maksym@gmail.com

@mxpv mxpv requested a review from Burning1020 September 25, 2022 20:15
Copy link
Member

@Burning1020 Burning1020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work @mxpv
I agree to add these config items despit of its instability.

Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Copy link
Member

@Burning1020 Burning1020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mxpv mxpv merged commit edb96dc into containerd:main Oct 2, 2022
@mxpv mxpv deleted the fmt branch October 2, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants