Use containerd's label package #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktock
force-pushed
the
ctdlabels
branch
3 times, most recently
from
fb51c09
to
41802e3
Compare
ktock
force-pushed
the
ctdlabels
branch
2 times, most recently
from
a12f099
to
22458c7
Compare
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
AkihiroSuda
reviewed
Mar 2, 2023
| // targetImageURLsLabelPrefix is a label prefix which constructs a map from the layer index to | ||
| // urls of the layer descriptor. This isn't contained in the set of the labels passed from CRI plugin but | ||
| // some clients (e.g. nerdctl) passes this for preserving url field in the OCI descriptor. | ||
| targetImageURLsLabelPrefix = "containerd.io/snapshot/remote/urls." |
There was a problem hiding this comment.
Should nerdctl use the CRI labels too?
Ok to preserve old labels for compatibility sake though
There was a problem hiding this comment.
nerdctl shoudl use containerd CRI labels (targetRefLabel+targetLayerDigestLabel+targetImageLayersLabel) + extra labels (targetImageURLsLabelPrefix+targetURLsLabel; they aren't defined/used by CRI). All of them should be needed for nerdctl to perform registry-based lazy pulling as well as IPFS-based lazy pulling.
AkihiroSuda
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes cri-related code to use containerd's exported label handling logic.
This PR also adds a helper function to append extra labels used for advanced functionalities like IPFS.
lazy pulling supported but no IPFS support:
lazy pulling supported and IPFS supported: