Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Additional Layer Store] Add authentication helper #1674

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

ktock
Copy link
Member

@ktock ktock commented May 14, 2024

Needs containers/image#2417

This commit adds a helper binary required by c/image for registry authentication of Additional Layer Store. This helper binary is registered to c/image using registries.conf with the following field (stargz-store-helper can be any command name of the helper binary). It receives registry creds via stdin and Additional Layer Store can use that creds for registry authentication.

additional-layer-store-auth-helper = "stargz-store-helper"

This binary is executed by c/image and recieves the registry creds from stdin and shares them to stargz-store daemon via an unix socket. c/image passes DockerAuthConfig structure keyed with the image reference.
When pulling the specified image, stargz-store uses the corresponding creds for registry authentication.

{
  "image-reference": {
    "username": "username",
    "password": "password",
    "identitytoken": "identitytoken"
  }
}

ktock added 2 commits October 4, 2024 16:14
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
@ktock ktock marked this pull request as ready for review October 4, 2024 11:12
@ktock ktock requested a review from AkihiroSuda October 7, 2024 07:10
@AkihiroSuda AkihiroSuda merged commit 01fd667 into containerd:main Oct 8, 2024
26 checks passed
@ktock ktock deleted the storeauth branch October 8, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants