Move prioritized files argument to option #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are cases where input tar entiy names are prefixed with "./" (which is still valid) but we shouldn't expose this difference in the option. So this commit also adds a simple normalization (trimming "./" prefix). Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
AkihiroSuda
reviewed
Dec 17, 2020
| // These files must be a complete path relative to "/" (e.g. "foo/bar", | ||
| // "./foo/bar") | ||
| func WithPrioritizedFiles(files []string) Option { | ||
| return func(o *options) { |
There was a problem hiding this comment.
This should verify files and return error.
Can be a follow-up PR.
There was a problem hiding this comment.
I'll work on it in the following up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#203
This moves prioritized files argument to option.
There are cases where input tar entiy names are prefixed with "./" (which is
still valid) but we shouldn't expose this difference in the option.
So this commit also adds a simple normalization (trimming "./" prefix).
Signed-off-by: Kohei Tokunaga ktokunaga.mail@gmail.com