Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and push stargz-snapshotter image usable as a kind node #940

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

ktock
Copy link
Member

@ktock ktock commented Oct 12, 2022

#715

This commit adds a CI to push Kind node image to ghcr.io/stargz-containers/${VERSION}-kind ghcr.io/containerd/stargz-snapshotter:${VERSION}-kindnamespace on each release.

$ cat /tmp/kindconfig.yaml 
kind: Cluster
apiVersion: kind.x-k8s.io/v1alpha4
nodes:
- role: control-plane
- role: worker
- role: worker
- role: worker
$ kind create cluster --config=/tmp/kindconfig.yaml --name stargz-demo --image ghcr.io/ktock/stargz-snapshotter:0.0.0-kind

- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When fetch-depth != 1 probably you want ref: ${{ github.event.pull_request.head.sha }} too, otherwise you'll get a merge commit that does not actually exist on the repo.

https://github.com/actions/checkout#checkout-pull-request-head-commit-instead-of-merge-commit

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review. Fixed to use fetch-depth == 1

@@ -0,0 +1,43 @@
name: Containerize
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: Containerize
name: kind image

or something else that is more descriptive

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the name to Kind image.

Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
@ktock
Copy link
Member Author

ktock commented Oct 13, 2022

This commit adds a CI to push Kind node image to ghcr.io/stargz-containers/${VERSION}-kind namespace on each release.

This looks like wrong... This workflow will to create the image at ghcr.io/containerd/stargz-snapshotter:${VERSION}-kind . (not stargz-containers)

cc @AkihiroSuda

@ktock ktock merged commit 016bb09 into containerd:main Oct 14, 2022
@ktock ktock deleted the containerizeci branch October 14, 2022 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants