-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and push stargz-snapshotter image usable as a kind node #940
Conversation
.github/workflows/containerize.yml
Outdated
- name: Checkout | ||
uses: actions/checkout@v3 | ||
with: | ||
fetch-depth: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When fetch-depth
!= 1 probably you want ref: ${{ github.event.pull_request.head.sha }}
too, otherwise you'll get a merge commit that does not actually exist on the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the review. Fixed to use fetch-depth
== 1
.github/workflows/containerize.yml
Outdated
@@ -0,0 +1,43 @@ | |||
name: Containerize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name: Containerize | |
name: kind image |
or something else that is more descriptive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the name to Kind image
.
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
This looks like wrong... This workflow will to create the image at cc @AkihiroSuda |
#715
This commit adds a CI to push Kind node image to
ghcr.io/stargz-containers/${VERSION}-kind
ghcr.io/containerd/stargz-snapshotter:${VERSION}-kind
namespace on each release.ghcr.io/ktock/stargz-snapshotter:0.0.0-kind