Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump nerdctl to 1.0.0 #969

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Bump nerdctl to 1.0.0 #969

merged 1 commit into from
Nov 2, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Nov 1, 2022

Signed-off-by: JenTing Hsiao hsiaoairplane@gmail.com

ktock
ktock approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@ktock ktock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@ktock
Copy link
Member

ktock commented Nov 1, 2022

CI failure of Tests / K3SArgoWorkflow looks unrelated to the change. (ref: #971)

https://github.com/containerd/stargz-snapshotter/actions/runs/3369629159/jobs/5589859528#step:8:13

result to /home/runner/work/stargz-snapshotter/stargz-snapshotter/argo-workflow//result.json
--2022-11-01 13:33:54--  https://raw.githubusercontent.com/argoproj/argo-workflows/stable/manifests/quick-start-minimal.yaml
Resolving raw.githubusercontent.com (raw.githubusercontent.com)... 185.199.109.133, 185.199.110.133, 185.199.111.133, ...
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|185.199.109.133|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2022-11-01 13:33:54 ERROR 404: Not Found.

@ktock
Copy link
Member

ktock commented Nov 2, 2022

@jenting #971 has been merged. Could you rebase this PR on the latest main commit?

@jenting
Bump nerdctl to 1.0.0
40b7b0a 
Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
ktock
ktock approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@ktock ktock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ktock ktock merged commit 8fd7d1f into containerd:main Nov 2, 2022
@jenting jenting deleted the bump-nerdctl branch November 2, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktock ktock ktock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jenting @ktock