Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap correct error on unix.GetsockoptUcred failure #100

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Wrap correct error on unix.GetsockoptUcred failure #100

merged 1 commit into from
Jan 21, 2022

Conversation

tklauser
Copy link
Contributor

Wrap ucredErr which is set by unix.GetsockoptUcred, not the nil err.

Wrap ucredErr which is set by unix.GetsockoptUcred, not the nil err.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2022

Codecov Report

Merging #100 (5b394b9) into main (0247db1) will increase coverage by 1.51%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   72.52%   74.03%   +1.51%     
==========================================
  Files          11       11              
  Lines         728      728              
==========================================
+ Hits          528      539      +11     
+ Misses        158      148      -10     
+ Partials       42       41       -1     
Impacted Files Coverage Δ
unixcreds_linux.go 53.84% <0.00%> (ø)
server.go 77.65% <0.00%> (+1.46%) ⬆️
client.go 82.08% <0.00%> (+3.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0247db1...5b394b9. Read the comment docs.

@dmcgowan dmcgowan merged commit 332f4c9 into containerd:main Jan 21, 2022
@tklauser tklauser deleted the ucred-wrap-err branch January 22, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants