Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update checkout and lint actions #109

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Conversation

dmcgowan
Copy link
Member

@dmcgowan dmcgowan commented Apr 7, 2022

Try to fix CI failures

Signed-off-by: Derek McGowan <derek@mcg.dev>
@codecov-commenter
Copy link

Codecov Report

Merging #109 (ff1e359) into main (b194a10) will increase coverage by 0.66%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   63.29%   63.96%   +0.66%     
==========================================
  Files          11       11              
  Lines        1049     1049              
==========================================
+ Hits          664      671       +7     
+ Misses        341      332       -9     
- Partials       44       46       +2     
Impacted Files Coverage Δ
src/github.com/containerd/ttrpc/server.go 75.07% <0.00%> (-0.94%) ⬇️
src/github.com/containerd/ttrpc/client.go 79.75% <0.00%> (+4.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b194a10...ff1e359. Read the comment docs.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -25,13 +25,13 @@ jobs:
os: [ubuntu-latest, macos-latest, windows-latest]

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've recently tried dependabot against ci.yml in one of my personal projects to automatically update dependencies like these. It worked very well, may be we should enable it against some containerd's repos.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, we can try it again

@dmcgowan dmcgowan merged commit bc84c40 into containerd:main Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants