Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only generate a Go file if the file has some services #112

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

kzys
Copy link
Member

@kzys kzys commented Apr 19, 2022

Otherwise, this generator creates a Go file with some import statements,
that causes "imported and not used" error.

Signed-off-by: Kazuyoshi Kato katokazu@amazon.com

Otherwise, this generator creates a Go file with some import statements,
that causes "imported and not used" error.

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #112 (f0fda53) into main (aa5c947) will decrease coverage by 1.97%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
- Coverage   63.87%   61.89%   -1.98%     
==========================================
  Files          11       12       +1     
  Lines        1049     1299     +250     
==========================================
+ Hits          670      804     +134     
- Misses        334      427      +93     
- Partials       45       68      +23     
Impacted Files Coverage Δ
src/github.com/containerd/ttrpc/client.go 64.06% <0.00%> (-13.22%) ⬇️
src/github.com/containerd/ttrpc/channel.go 73.17% <0.00%> (-8.37%) ⬇️
src/github.com/containerd/ttrpc/server.go 73.79% <0.00%> (-2.84%) ⬇️
src/github.com/containerd/ttrpc/interceptor.go 100.00% <0.00%> (ø)
src/github.com/containerd/ttrpc/stream.go 81.48% <0.00%> (ø)
src/github.com/containerd/ttrpc/services.go 60.24% <0.00%> (+12.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa5c947...f0fda53. Read the comment docs.

@mxpv mxpv merged commit 944ef4a into containerd:main Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants