Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cnitool install procedure #106

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Joffref
Copy link

@Joffref Joffref commented Aug 9, 2022

As describe here : https://golang.org/doc/go-get-install-deprecation, go get no longer works without a go module.
Signed-off-by: Sugate mariusjoffre@gmail.com

As describe here : https://golang.org/doc/go-get-install-deprecation, go get no longer works without a go module.
Signed-off-by: Sugate <mariusjoffre@gmail.com>
@squeed
Copy link
Member

squeed commented Jan 17, 2023

oh, good catch. Do we even need the first go get? Probably not?

@Joffref
Copy link
Author

Joffref commented Jan 17, 2023

Tbh, I don't know. This PR is quite old, maybe we should give another try to be sure that this snippet work fully.

@Joffref
Copy link
Author

Joffref commented Aug 19, 2023

I've recently tested it and yes: the first go install is unnecessary. Updating the PR according.

Signed-off-by: Joffref <mariusjoffre@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants