Document nftables backends for portmap and ipmasq #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LionelJouin
reviewed
Sep 2, 2024
aojea
reviewed
Sep 3, 2024
aojea
reviewed
Sep 3, 2024
aojea
reviewed
Sep 3, 2024
| * Plugins whose traffic does not go through the default net namespace e.g., ipvlan,macvlan,etc. (need `masqAll` option) | ||
|
|
||
| Unlike the iptables backend, the nftables backend figures out the | ||
| packets that need to be masqueraded without using the packet mark or |
|
LGTM, modulo the two typos |
Also belatedly remove the recommendation of using `"externalSetMarkChain": "KUBE-MARK-MASQ"`. Signed-off-by: Dan Winship <danwinship@redhat.com>
aojea
approved these changes
Sep 3, 2024
squeed
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(to sync with containernetworking/plugins#935)
Also belatedly remove the recommendation of using
"externalSetMarkChain": "KUBE-MARK-MASQ".cc @squeed @aojea