Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SocketPath/PciID to Interface struct #1069

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Add SocketPath/PciID to Interface struct #1069

merged 1 commit into from
Mar 4, 2024

Conversation

MikeZappa87
Copy link
Contributor

@MikeZappa87 MikeZappa87 commented Feb 19, 2024 •
edited
Loading

This is to resolve: #1050

@coveralls
Copy link

coveralls commented Feb 26, 2024 •
edited
Loading

Coverage Status

coverage: 70.133%. remained the same
when pulling 163db33 on MikeZappa87:spec/socketpci
into b62753a on containernetworking:main.

@MikeZappa87 MikeZappa87 marked this pull request as ready for review February 26, 2024 15:30
@squeed
Copy link
Member

squeed commented Feb 26, 2024

Looks good; we need to add this to the spec, though.

@MikeZappa87
Copy link
Contributor Author

Looks good; we need to add this to the spec, though.

I can start on that right now.

squeed
squeed reviewed Feb 26, 2024
View reviewed changes
pkg/types/100/types_test.go Outdated Show resolved Hide resolved
@MikeZappa87 MikeZappa87 force-pushed the spec/socketpci branch 2 times, most recently from 8485501 to 330a4a7 Compare February 26, 2024 17:31
@MikeZappa87 MikeZappa87 linked an issue Feb 26, 2024 that may be closed by this pull request
Proposal: Add metadata map field to Interface object in CNI Result #1050
Closed
@MikeZappa87 MikeZappa87 self-assigned this Feb 26, 2024
@MikeZappa87 MikeZappa87 added this to the CNI v1.1 milestone Feb 26, 2024
@MikeZappa87
Copy link
Contributor Author

@squeed this should be ready

tamilmani1989
tamilmani1989 approved these changes Feb 26, 2024
View reviewed changes
Copy link

@tamilmani1989 tamilmani1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

s1061123
s1061123 requested changes Mar 4, 2024
View reviewed changes
SPEC.md Outdated Show resolved Hide resolved
squeed
squeed reviewed Mar 4, 2024
View reviewed changes
SPEC.md Outdated Show resolved Hide resolved
squeed
squeed reviewed Mar 4, 2024
View reviewed changes
SPEC.md Outdated Show resolved Hide resolved
@MikeZappa87
Add socket path and pciid to CNI interface result
163db33 
Signed-off-by: Michael Zappa <michaelzappa@microsoft.com>
@squeed squeed merged commit c822f13 into containernetworking:main Mar 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamilmani1989 tamilmani1989 tamilmani1989 approved these changes

@squeed squeed squeed approved these changes

@s1061123 s1061123 s1061123 approved these changes

Assignees

@MikeZappa87 MikeZappa87

Labels
None yet
Projects
None yet
Milestone
CNI v1.1
Development

Successfully merging this pull request may close these issues.

Proposal: Add metadata map field to Interface object in CNI Result
5 participants
@MikeZappa87 @coveralls @squeed @s1061123 @tamilmani1989