Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types changes for 1.0.0 #783

Merged
merged 4 commits into from
Nov 19, 2020
Merged

types changes for 1.0.0 #783

merged 4 commits into from
Nov 19, 2020

Commits on Oct 28, 2020

  1. types: implement convert module and make types use it

    Moving to spec 1.0.0 requires more complicated conversions, so
    put the converter determination logic in a separate module that
    any of the types can call to convert between arbitrary versions.
    This is necessary to ensure the types don't have import cycles.
    
    This also implements downconversion, which we never claimed
    *not* to support, but didn't implement.
    
    It also verifies that the Result object unmarshalled by
    each result type's NewResult() function is actually supported
    by the result type. This is a potentially breaking change as
    this was not previously done, and for example may now fail
    attempts to read a cached PrevResult written by a previous
    version.
    
    Signed-off-by: Dan Williams <dcbw@redhat.com>
    dcbw committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    0050bfa View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2020

  1. types: add 1.0.0

    Only change this time is removal of the IPConfig "Version" field
    which was deemed redundant.
    
    Signed-off-by: Dan Williams <dcbw@redhat.com>
    dcbw committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    3805b13 View commit details
    Browse the repository at this point in the history
  2. tests: small cleanup and removal of one useless testcase

    The testcase checking if a prevResult was invalid is not actually
    useful, because it was testing that an empty prevResult could be
    unmarshalled. But due to an oversight, prevResults may not have
    a CNIVersion key, which is all we can check for validity.
    
    Signed-off-by: Dan Williams <dcbw@redhat.com>
    dcbw committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    6823eba View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2020

  1. spec: bump to 1.0.0-pre-release and remove 'version' from Result addr…

    …esses
    
    Redundant and easily determined from the address itself.
    
    Signed-off-by: Dan Williams <dcbw@redhat.com>
    dcbw committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    7555ca3 View commit details
    Browse the repository at this point in the history