cnitool: deduplicate environment variable definitions #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squeed
reviewed
Nov 14, 2022
squeed
reviewed
Nov 14, 2022
squeed
reviewed
Nov 14, 2022
|
This looks basically reasonable, but any of the environment variables that are |
squeed
reviewed
Nov 14, 2022
UiP9AV6Y
force-pushed
the
feature_dedupe_env
branch
from
fb89176
to
55e376e
Compare
|
i have moved all furthermore i have moved the CNI Args parsing logic into |
UiP9AV6Y
force-pushed
the
feature_dedupe_env
branch
from
55e376e
to
c8fd9aa
Compare
mars1024
reviewed
Nov 21, 2022
|
|
||
| // supported CNI_COMMAND values | ||
|
|
||
| CmdAdd = "ADD" |
There was a problem hiding this comment.
Since pkg/env is supposed to be a tool package, is it better to place this constants on another package, maybe pkg/constants?
UiP9AV6Y
force-pushed
the
feature_dedupe_env
branch
from
c8fd9aa
to
42aa09f
Compare
create a reusable package for environment variables to be used by `cnitool` and the other library code. Signed-off-by: Gordon Bleux <33967640+UiP9AV6Y@users.noreply.github.com>
UiP9AV6Y
force-pushed
the
feature_dedupe_env
branch
from
42aa09f
to
99bb7b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create a reusable package for environment variable to be used by
cnitooland the other library code.Signed-off-by: Gordon Bleux 33967640+UiP9AV6Y@users.noreply.github.com