-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flaky SBR tests due to routes with link-local IP #1096
Comments
LionelJouin
changed the title
Flacky SBR tests due to routes with link-local IP
Flaky SBR tests due to routes with link-local IP
Sep 20, 2024
We talked about this at the meeting; we will just ignore link-local routes in the tests. the issue, unsurprisingly, is ipv6 DAD. |
LionelJouin
added a commit
to LionelJouin/plugins
that referenced
this issue
Sep 30, 2024
The tests were flaky due to a route with the link-local IP being automatically added after the test run saves the initial state (routes before SBR plugin is ran). When the SBR plugin is ran, the new state is compared with the old state. The new state will then contain the route with the link-local IP (that has been added after saving the old state), the old state was not containing it, so the tests were failing The solution here is to ignore routes with the link-local IP for the tests. fixes: containernetworking#1096 Signed-off-by: Lionel Jouin <lionel.jouin@est.tech>
squeed
pushed a commit
that referenced
this issue
Sep 30, 2024
The tests were flaky due to a route with the link-local IP being automatically added after the test run saves the initial state (routes before SBR plugin is ran). When the SBR plugin is ran, the new state is compared with the old state. The new state will then contain the route with the link-local IP (that has been added after saving the old state), the old state was not containing it, so the tests were failing The solution here is to ignore routes with the link-local IP for the tests. fixes: #1096 Signed-off-by: Lionel Jouin <lionel.jouin@est.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Here is an example of fail test run: https://github.com/containernetworking/plugins/actions/runs/10952855591/job/30412240836?pr=1092
This is due to a route with the link-local IP being automatically added after the test run saves the initial state (routes before SBR plugin is ran). When the SBR plugin is ran, the new state is compared with the old state. The new state will then contain the route with the link-local IP (that has been added after saving the old state), the old state was not containing it, so the tests were failing
A solution would be to ignore routes with the link-local IP for the tests, or to somehow wait for the routes with the link-local IP to be created.
The text was updated successfully, but these errors were encountered: