Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky SBR tests due to routes with link-local IP #1096

Closed
LionelJouin opened this issue Sep 20, 2024 · 1 comment · Fixed by #1102
Closed

Flaky SBR tests due to routes with link-local IP #1096

LionelJouin opened this issue Sep 20, 2024 · 1 comment · Fixed by #1102

Comments

@LionelJouin
Copy link
Member

LionelJouin commented Sep 20, 2024 •
edited
Loading

Here is an example of fail test run: https://github.com/containernetworking/plugins/actions/runs/10952855591/job/30412240836?pr=1092

This is due to a route with the link-local IP being automatically added after the test run saves the initial state (routes before SBR plugin is ran). When the SBR plugin is ran, the new state is compared with the old state. The new state will then contain the route with the link-local IP (that has been added after saving the old state), the old state was not containing it, so the tests were failing

A solution would be to ignore routes with the link-local IP for the tests, or to somehow wait for the routes with the link-local IP to be created.
@LionelJouin LionelJouin changed the title Flacky SBR tests due to routes with link-local IP Flaky SBR tests due to routes with link-local IP Sep 20, 2024
@LionelJouin LionelJouin mentioned this issue Sep 20, 2024
Merged
@squeed
Copy link
Member

squeed commented Sep 30, 2024

We talked about this at the meeting; we will just ignore link-local routes in the tests.

the issue, unsurprisingly, is ipv6 DAD.

LionelJouin added a commit to LionelJouin/plugins that referenced this issue Sep 30, 2024
@LionelJouin
Ignore link-local routes in SBR tests
82cc11a 
The tests were flaky due to a route with the link-local IP being
automatically added after the test run saves the initial state
(routes before SBR plugin is ran). When the SBR plugin is ran,
the new state is compared with the old state. The new state will
then contain the route with the link-local IP (that has been
added after saving the old state), the old state was not
containing it, so the tests were failing

The solution here is to ignore routes with the link-local IP
for the tests.

fixes: containernetworking#1096

Signed-off-by: Lionel Jouin <lionel.jouin@est.tech>
@LionelJouin LionelJouin mentioned this issue Sep 30, 2024
Merged
squeed pushed a commit that referenced this issue Sep 30, 2024
@LionelJouin @squeed
Ignore link-local routes in SBR tests
c11ed48 
The tests were flaky due to a route with the link-local IP being
automatically added after the test run saves the initial state
(routes before SBR plugin is ran). When the SBR plugin is ran,
the new state is compared with the old state. The new state will
then contain the route with the link-local IP (that has been
added after saving the old state), the old state was not
containing it, so the tests were failing

The solution here is to ignore routes with the link-local IP
for the tests.

fixes: #1096

Signed-off-by: Lionel Jouin <lionel.jouin@est.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore link-local routes in SBR tests LionelJouin/plugins
2 participants
@squeed @LionelJouin