ptp: add ipv6 support #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
squeed
commented
Jun 16, 2017
squeed
commented
- Wait for addresses to leave tentative state before setting routes
- Enable forwarding correctly
- Set up masquerading according to the active protocol
dcbw
requested changes
Jun 28, 2017
plugins/main/ptp/ptp.go
Outdated
| @@ -84,6 +84,11 @@ func setupContainerVeth(netns ns.NetNS, ifName string, mtu int, pr *current.Resu | |||
| return err | |||
| } | |||
|
|
|||
| // Wait for addresses to leave tentative state (for up to 10 seconds) | |||
| if err := ip.SettleAddresses(ifName, 10); err != nil { | |||
There was a problem hiding this comment.
Should we just make ConfigureIface() handle the settling? That might reduce code in the plugins a bit; we'd still need the Settle call for standalone IP assignment like bridge.go does though.
|
@dcbw updated. I added a stricter testcase that actually shells out to ping (don't hit me). Can you check that I got SettleAddresses right? |
* Wait for addresses to leave tentative state before setting routes * Enable forwarding correctly * Set up masquerading according to the active protocol
dcbw
approved these changes
Jul 5, 2017
|
LGTM |
5 tasks
mansikulkarni96
pushed a commit
to mansikulkarni96/plugins
that referenced
this pull request
Apr 18, 2022
Upgrade to v0.8.5 tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.