static: prioritize the input sources for IPs #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1061123
force-pushed
the
fix/overwrite-ips
branch
2 times, most recently
from
3d381c3 to
ec6abcb
Compare
mars1024
reviewed
Oct 15, 2019
dcbw
reviewed
Oct 16, 2019
|
Can you add some tests for this? Thanks! |
This change introduce priorities for IPs input among CNI_ARGS, 'args' and runtimeConfig. Fix containernetworking#399. Signed-off-by: Tomofumi Hayashi <tohayash@redhat.com>
s1061123
force-pushed
the
fix/overwrite-ips
branch
from
ec6abcb to
2290fc8
Compare
|
@squeed thank you for your comment! I added a testcase. |
|
Am I right in thinking there was a priority order before, and this PR changes the ordering? |
|
Given that this is a (small) change in behavior, we should probably bump the version when we next do a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduce priorities for IPs input among CNI_ARGS, 'args' and runtimeConfig.
Fix #399
Signed-off-by: Tomofumi Hayashi tohayash@redhat.com