Fix "config is \"1.0.0\", plugin supports [\"0.4.0\"]"
#652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance to release v1.0.1 with this? |
|
@squeed Can you take a look at this? |
squeed
reviewed
Sep 1, 2021
squeed
reviewed
Sep 1, 2021
|
@AkihiroSuda sorry for missing this - was on vacation. Two small changes - can you make them? |
squeed
reviewed
Sep 1, 2021
Some plugins could not be executed with `cniVersion: "1.0.0"` JSON because `version.Current()` was not included in `version.PluginSupports()` checks. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
fix-cni100
branch
from
3cdb6d2
to
bef2357
Compare
|
Hey, thanks for discovering this! It turns out there were a few more that needed fixing, so I filed a separate PR: #661 |
|
And v1.0.1 is released 🤦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some plugins could not be executed with
cniVersion: "1.0.0"JSON becauseversion.Current()was not included inversion.PluginSupports()checks.