Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decouple internal testing farm tasks #407

Closed
wants to merge 1 commit into from

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Nov 6, 2023

This way non-internal testing farm tasks don't have to wait on approval from someone with commit access to the repo. Especially useful for update PRs created by Renovate.

The integration tests run on the internal testing farm are linked to this new build job using the same identifier integration_test_internal.

Copy link
Contributor

openshift-ci bot commented Nov 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@lsm5
Copy link
Member Author

lsm5 commented Nov 6, 2023

I guess this can only be verified after it's merged and renovate or a non-committer creates a PR. Also, this change should not create rpm-build:fedora-* tasks but right now they are getting created because of packit/packit-service#2131 .

This way non-internal testing farm tasks don't have to wait on approval
from someone with commit access to the repo. Especially useful for
update PRs created by Renovate.

The integration tests run on the internal testing farm are linked to
this new build job using the same identifier `integration_test_internal`.

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
Copy link
Member Author

lsm5 commented Nov 15, 2023

@Luap99 PTAL

@Luap99
Copy link
Member

Luap99 commented Nov 15, 2023

There seems to be a bunch of duplicated tasks for the rpm-build tasks now??

@lsm5
Copy link
Member Author

lsm5 commented Nov 15, 2023

There seems to be a bunch of duplicated tasks for the rpm-build tasks now??

@Luap99 the ones for epel are expected, we need a separate build job for use by internal testing farm jobs. The duplicated tasks for fedora are being tracked in the packit issue.

@Luap99
Copy link
Member

Luap99 commented Nov 15, 2023

But we do need twice the same job? IS there no way to make it only build once and have the RHEL task consume the right build?

Doing the exact same thing twice is totally wasting resource increasing odds for flakes and totally confusing when looking at this job list.

@Luap99
Copy link
Member

Luap99 commented Nov 15, 2023

Or maybe asking the other way around, couldn't we drop the existing build taks then? I feel like I missing how this is supposed to work.

@baude
Copy link
Member

baude commented Nov 27, 2023

what say you @lsm5

@lsm5
Copy link
Member Author

lsm5 commented May 3, 2024

This can be closed. With the merging of #458 , the fedora jobs at least should run for all PRs regardless of the PR submitter being maintainer / outside contributor. I suspect the centos 9 jobs should run the same way as fedora jobs and only rhel9 jobs will need a maintainer to trigger them. Guess we'll find out in upcoming PRs. Worst case, a maintainer can trigger them all.

@lsm5 lsm5 closed this May 3, 2024
@Luap99
Copy link
Member

Luap99 commented May 3, 2024

@lsm5 yes it seems to work if I look at #456

@lsm5 lsm5 deleted the tmt-internal branch May 3, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants