-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decouple internal testing farm tasks #407
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ephemeral COPR build failed. @containers/packit-build please check. |
I guess this can only be verified after it's merged and renovate or a non-committer creates a PR. Also, this change should not create rpm-build:fedora-* tasks but right now they are getting created because of packit/packit-service#2131 . |
This way non-internal testing farm tasks don't have to wait on approval from someone with commit access to the repo. Especially useful for update PRs created by Renovate. The integration tests run on the internal testing farm are linked to this new build job using the same identifier `integration_test_internal`. Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@Luap99 PTAL |
There seems to be a bunch of duplicated tasks for the rpm-build tasks now?? |
@Luap99 the ones for epel are expected, we need a separate build job for use by internal testing farm jobs. The duplicated tasks for fedora are being tracked in the packit issue. |
But we do need twice the same job? IS there no way to make it only build once and have the RHEL task consume the right build? Doing the exact same thing twice is totally wasting resource increasing odds for flakes and totally confusing when looking at this job list. |
Or maybe asking the other way around, couldn't we drop the existing build taks then? I feel like I missing how this is supposed to work. |
what say you @lsm5 |
This can be closed. With the merging of #458 , the fedora jobs at least |
This way non-internal testing farm tasks don't have to wait on approval from someone with commit access to the repo. Especially useful for update PRs created by Renovate.
The integration tests run on the internal testing farm are linked to this new build job using the same identifier
integration_test_internal
.