fixing testing framework with image ref being moved #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gregory-Pereira
requested review from
MichaelClifford,
rhatdan,
sallyom,
lmilbaum and
cgwalters
as code owners
Gregory-Pereira
force-pushed
the
fix-testing-framwork-llamacpp-ref
branch
2 times, most recently
from
80091d6
to
720bb2f
Compare
|
For clarification this issue came to light because #292 got merged and I scrubbed the unused resource from |
Signed-off-by: greg pereira <grpereir@redhat.com>
Gregory-Pereira
force-pushed
the
fix-testing-framwork-llamacpp-ref
branch
from
720bb2f
to
5db0a4d
Compare
Closed
|
I am fine with this naming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @lmilbaum @sallyom this should fix it