-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Ilab container builds #509
base: main
Are you sure you want to change the base?
Conversation
a9d31e0
to
6ca1848
Compare
Yes I was. Because that change broke all of our workflows which automatically produce our ai-lab ilab based images. Because of this our e2e runs have not worked. Although I guess a potential alternative implementation would be swapping CI to work with an action build rather than a |
We need these to be stored as OCI images for speed of building and saving of disk space. Lets work on some other mechanism to fix the ci sysem. |
Understood, ill update my implementation shortly. |
f3595fe
to
ec862bb
Compare
This implementation should preserve the OCI transfer implementaiton Signed-off-by: greg pereira <grpereir@redhat.com>
48bc575
to
69f090a
Compare
Signed-off-by: greg pereira <grpereir@redhat.com>
2b43d2d
to
894f5a7
Compare
CI is broken |
Signed-off-by: greg pereira <grpereir@redhat.com>
894f5a7
to
bb44d08
Compare
@rhatdan @lmilbaum @Gregory-Pereira in regards to the e2e/ilab testing will we keep maintaining this or will this go into official repos such as the rhelai repository? |
I think we should keep the project as an open project, so the Training bits should stay here. |
Will try to prioritize the stability of the e2e tests then next week |
Reverting to least blocked action run: https://github.com/containers-mirror/ai-lab-recipes/actions/runs/8903515843/job/24451391934#step:4:32