Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify package installation #511

Merged
merged 1 commit into from
May 23, 2024
Merged

Simplify package installation #511

merged 1 commit into from
May 23, 2024

Conversation

enriquebelarte
Copy link
Collaborator

Installs epel and CRB in a cleaner way.

lmilbaum
lmilbaum approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@lmilbaum lmilbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmilbaum
Copy link
Collaborator

Is it an option to use variables instead of if/else commands?

@enriquebelarte
Copy link
Collaborator Author

enriquebelarte commented May 23, 2024 •
edited
Loading

Is it an option to use variables instead of if/else commands?

Maybe for the KERNEL_VERSION, TARGET_ARCH and OS_VERSION_MAJOR we could leave out the conditionals (IINM there's no else) and add variables which could be cleaner and better for CI ? . Regarding the packages based on different OSes I think it's OK as it is now, but I accept suggestions.

@enriquebelarte
Simplify package installation
c42d2a2 
Installs epel and CRB in a cleaner way.

Signed-off-by: Enrique Belarte Luque <ebelarte@redhat.com>
@rhatdan
Copy link
Member

rhatdan commented May 23, 2024

/approve
/lgtm

@lmilbaum lmilbaum merged commit 3d5a294 into containers:main May 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmilbaum lmilbaum lmilbaum approved these changes

@MichaelClifford MichaelClifford Awaiting requested review from MichaelClifford MichaelClifford is a code owner

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

@sallyom sallyom Awaiting requested review from sallyom sallyom is a code owner

@cgwalters cgwalters Awaiting requested review from cgwalters cgwalters is a code owner

@Gregory-Pereira Gregory-Pereira Awaiting requested review from Gregory-Pereira Gregory-Pereira is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enriquebelarte @lmilbaum @rhatdan