-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix testing-framework #660
Conversation
@Gregory-Pereira @cooktheryan @lmilbaum ptal, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm, just reccomend removing 1 debug step but either way it passes muster, thanks
export TRACE_ACTION="start" | ||
python ci/trace-steps.py | ||
- name: Debug - List directory contents | ||
run: ls -al ./recipes/natural_language_processing/chatbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need it, i'll remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: sallyom <somalley@redhat.com>
291c31b
to
1ed1d0d
Compare
@Gregory-Pereira I removed the debug statement and also re-commented the |
remove trace steps to isolate the path issue, then fix the path issue