Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix testing-framework #660

Merged
merged 1 commit into from
Jul 10, 2024
Merged

fix testing-framework #660

merged 1 commit into from
Jul 10, 2024

Conversation

sallyom
Copy link
Collaborator

@sallyom sallyom commented Jul 7, 2024

remove trace steps to isolate the path issue, then fix the path issue

@sallyom
Copy link
Collaborator Author

sallyom commented Jul 7, 2024

@Gregory-Pereira @cooktheryan @lmilbaum ptal, thanks!

Copy link
Collaborator

@Gregory-Pereira Gregory-Pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm, just reccomend removing 1 debug step but either way it passes muster, thanks

export TRACE_ACTION="start"
python ci/trace-steps.py
- name: Debug - List directory contents
run: ls -al ./recipes/natural_language_processing/chatbot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need it, i'll remove it

Copy link
Collaborator

@lmilbaum lmilbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: sallyom <somalley@redhat.com>
@sallyom sallyom force-pushed the fix-testing-framework branch from 291c31b to 1ed1d0d Compare July 9, 2024 12:37
@sallyom
Copy link
Collaborator Author

sallyom commented Jul 9, 2024

@Gregory-Pereira I removed the debug statement and also re-commented the on section to run on PR

@rhatdan rhatdan merged commit c989117 into main Jul 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants