nvidia-bootc: Duplicate common lib & ilab, to avoid an intermediate makefile target #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pastequo
requested review from
MichaelClifford,
rhatdan,
sallyom,
lmilbaum,
cgwalters and
Gregory-Pereira
as code owners
|
@rhatdan ptal |
pastequo
commented
Jul 25, 2024
| if [ -f "/run/.input/ilab" ]; then \ | ||
| cp /run/.input/ilab /usr/bin/ilab; \ | ||
| else \ | ||
| curl -o /usr/bin/ilab "https://raw.githubusercontent.com/containers/ai-lab-recipes/main/training/ilab-wrapper/ilab"; \ |
There was a problem hiding this comment.
I though it was better to always pick the local version, to have build reproducibility
rhatdan
reviewed
Jul 25, 2024
pastequo
commented
Jul 25, 2024
|
/hold |
pastequo
force-pushed
the
nvidia-bootc/feat/remove-makefile-step
branch
from
55de489 to
d026c6b
Compare
|
@romfreiman New version, dupplicating lib & ilab |
pastequo
force-pushed
the
nvidia-bootc/feat/remove-makefile-step
branch
from
d026c6b to
d30fa2c
Compare
…flux without running makefile targets
pastequo
force-pushed
the
nvidia-bootc/feat/remove-makefile-step
branch
from
d30fa2c to
cc5c4d7
Compare
|
LGTM |
pastequo
changed the title
javipolo
approved these changes
Jul 25, 2024
|
Can we fix DCO? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a discussion with @ralphbean , it would be preferable to avoid any makefile command before building this image in Konflux.
This PR dupplicates the required files