Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHELAI-744 - Use environment variable to override HOME in ilab wrapper #709

Merged
merged 1 commit into from
Aug 1, 2024
Merged

RHELAI-744 - Use environment variable to override HOME in ilab wrapper #709

merged 1 commit into from
Aug 1, 2024

Conversation

javipolo
Copy link
Collaborator

No description provided.

@rhatdan
Copy link
Member

rhatdan commented Jul 31, 2024

Why wouldn't I just override HOME?

HOME=/tmp/foobar ilab ...

@fabiendupont
Copy link
Contributor

The ILAB_HOME variable can be persistent (.bash_profile...), so that the user doesn't have to type HOME=/tmp/foobar on every command line. And alias would also work, but a convention on an environment variable name is easier to override for tests.

@javipolo javipolo force-pushed the ilab_home_override branch from 30c449f to 107f8a9 Compare July 31, 2024 14:59
@javipolo javipolo changed the title Allow to override HOME to easily use a different data directory with ilab wrapper RHELAI-744 - Use environment variable to override HOME in ilab wrapper Jul 31, 2024
@rhatdan
Copy link
Member

rhatdan commented Aug 1, 2024

LGTM

@rhatdan rhatdan merged commit a152539 into containers:main Aug 1, 2024
1 check passed
@javipolo javipolo deleted the ilab_home_override branch August 1, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelClifford MichaelClifford Awaiting requested review from MichaelClifford MichaelClifford is a code owner

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

@sallyom sallyom Awaiting requested review from sallyom sallyom is a code owner

@lmilbaum lmilbaum Awaiting requested review from lmilbaum

@cgwalters cgwalters Awaiting requested review from cgwalters cgwalters is a code owner

@Gregory-Pereira Gregory-Pereira Awaiting requested review from Gregory-Pereira Gregory-Pereira is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javipolo @rhatdan @fabiendupont