Require KERNEL_VERSION argument in driver-toolkit #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiendupont
requested review from
MichaelClifford,
rhatdan,
sallyom,
lmilbaum,
cgwalters and
Gregory-Pereira
as code owners
rhatdan
reviewed
Aug 2, 2024
| && export KERNEL_VERSION="${VERSION}-${RELEASE}" ;\ | ||
| fi \ | ||
| && echo "${KERNEL_VERSION}" \ | ||
| RUN if [ "${KERNEL_VERSION}" == "" ] ; then \ |
There was a problem hiding this comment.
I prefer
test -z ${KERNEL_VERSION}
There was a problem hiding this comment.
If this is not a bootable container image ,is there a reason for requiring the kernel?
There was a problem hiding this comment.
The Driver Toolkit is only used to compile out-of-tree kernel modules. It is used for the intel-bootc and nvidia-bootc image build with a multi-stage approach. The drivers are built in DriverToolkit, then copied over the final image, which is bootable.
The default base image for the Driver Toolkit image is `centos:stream9`. The original work for Driver Toolkit is in OpenShift and the base image is `ubi9/ubi`. In bother cases, the images don't have the `kernel` package installed. This change adds a test on the `KERNEL_VERSION` argument and exits if it's not provided at build time. This also ensure that only the relevant kernel is present when using `centos:stream9` or `ubi9/ubi` as the base image. And this realigns a bit with the original Driver Toolkit. Signed-off-by: Fabien Dupont <fdupont@redhat.com>
fabiendupont
force-pushed
the
simplify-driver-toolkit
branch
from
a533e89 to
1a16a7a
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default base image for the Driver Toolkit image is
centos:stream9. The original work for Driver Toolkit is in OpenShift and the base image isubi9/ubi. In bother cases, the images don't have thekernelpackage installed.This change adds a test on the
KERNEL_VERSIONargument and exits if it's not provided at build time. This also ensure that only the relevant kernel is present when usingcentos:stream9orubi9/ubias the base image. And this realigns a bit with the original Driver Toolkit.