Driver Toolkit: Get kernel version from bootc image #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiendupont
requested review from
MichaelClifford,
rhatdan,
sallyom,
lmilbaum,
cgwalters and
Gregory-Pereira
as code owners
javipolo
requested changes
Aug 7, 2024
fabiendupont
force-pushed
the
get-kernel-version-from-bootc-image
branch
2 times, most recently
from
377a775 to
0a5a1a3
Compare
When building the `driver-toolkit` image, It is cumbersome to find kernel
version that matches the future `nvidia-bootc` and `intel-bootc` images.
However, the kernel version is stored as a label on the `rhel-bootc`
images, which are exposed as the `FROM` variable in the Makefile.
This change collects the kernel version using `skopeo inspect` and `jq`.
The `DRIVER_TOOLKIT_BASE_IMAGE` variable is introduced in the Makefile
to dissociate it from the `FROM` variable that is used as the `nvidia-bootc`
and `intel-bootc` base image.
The user can now specify something like:
```shell
make nvidia-bootc \
FROM=quay.io/centos-bootc/centos-bootc:stream9 \
DRIVER_TOOLKIT_BASE_IMAGE=quay.io/centos/centos:stream9
```
Also, the `VERSION` variable in `/etc/os-release` is the full version, so
this change modifies the command to retrieve the `OS_VERSION_MAJOR`
value.
Signed-off-by: Fabien Dupont <fdupont@redhat.com>
fabiendupont
force-pushed
the
get-kernel-version-from-bootc-image
branch
from
0a5a1a3 to
78c57fe
Compare
lmilbaum
approved these changes
Aug 8, 2024
javipolo
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Driver Toolkit: Get kernel version from bootc image
When building the
driver-toolkitimage, It is cumbersome to find kernelversion that matches the future
nvidia-bootcandintel-bootcimages.However, the kernel version is stored as a label on the
rhel-bootcimages, which are exposed as the
FROMvariable in the Makefile.This change collects the kernel version using
skopeo inspectandjq.The
DRIVER_TOOLKIT_BASE_IMAGEvariable is introduced in the Makefileto dissociate it from the
FROMvariable that is used as thenvidia-bootcand
intel-bootcbase image.The user can now specify something like:
make nvidia-bootc \ FROM=quay.io/centos-bootc/centos-bootc:stream9 \ DRIVER_TOOLKIT_BASE_IMAGE=quay.io/centos/centos:stream9Also, the
VERSIONvariable in/etc/os-releaseis the full version, sothis change modifies the command to retrieve the
OS_VERSION_MAJORvalue.
Signed-off-by: Fabien Dupont fdupont@redhat.com