Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHELAI-838 Enforce insights registration in ilab wrapper #745

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

javipolo
Copy link
Collaborator

@javipolo javipolo commented Aug 8, 2024

I'd also appreciate if a native english speaker could review the error message displayed

/cc @fabiendupont

@fabiendupont
Copy link
Contributor

Looks good to me, but I'm not a native english speaker :)

training/ilab-wrapper/ilab Outdated Show resolved Hide resolved
training/ilab-wrapper/ilab Show resolved Hide resolved
Signed-off-by: Javi Polo <jpolo@redhat.com>
@javipolo javipolo requested a review from jeremyeder August 8, 2024 16:05
@jeremyeder
Copy link
Contributor

LGTM

1 similar comment
@rhatdan
Copy link
Member

rhatdan commented Aug 8, 2024

LGTM

Copy link
Member

@rhatdan rhatdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan rhatdan merged commit 42e77cb into containers:main Aug 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants