Add customizations per cloud provider #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javipolo
requested review from
MichaelClifford,
rhatdan,
sallyom,
lmilbaum,
cgwalters and
Gregory-Pereira
as code owners
|
/cc @fabiendupont PTAL ::) |
javipolo
force-pushed
the
cloud-providers
branch
3 times, most recently
from
088e40d to
e7b1c9a
Compare
Signed-off-by: Javi Polo <jpolo@redhat.com>
javipolo
force-pushed
the
cloud-providers
branch
from
e7b1c9a to
e7e7c96
Compare
rhatdan
reviewed
Sep 3, 2024
| @@ -9,9 +9,6 @@ In order to run accelerated AI workloads, we've prepared [bootc](https://github. | |||
| |-----------------|---------------------------------------------------------------------| | |||
| | amd | Create bootable container for AMD platform | | |||
| | deepspeed | DeepSpeed container for optimization deep learning | | |||
| | cloud-amd | Add cloud-init to bootable container for AMD platform | | |||
There was a problem hiding this comment.
Moving this is fine, but you should point add a section about building the images for different clouds and then link them together.
There was a problem hiding this comment.
In this case is not moving, but removing, since cloud-amd, cloud-nvidia and cloud-intel targets have been removed long time ago
There was a problem hiding this comment.
Do we have anything in the README that talks about cloud images? If not, we should.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.