Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: add podman_container_copy module #813

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Proposal: add podman_container_copy module #813

merged 1 commit into from
Aug 13, 2024

Conversation

kubealex
Copy link
Contributor

As the title suggests, this PR covers a draft proposal of a module for podman cp command.

It basically reflects the podman cp usage, allowing host -> container copy (default) or container -> host (configurable via a parameter).

Attached are also the tests for both flows (host->container, container->host)

@sshnaidm
Copy link
Member

@kubealex awesome,thanks for contribution! I'll review it asap. For running tests in this patch it's better to include all CI bits from here: #531 Just replace "podman_lovely" with "podman_container_copy"

@kubealex
Copy link
Contributor Author

thank you @sshnaidm!
I just added the CI part, fixed the issue and squashed the commits to a single one.

Copy link
Member

@sshnaidm sshnaidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments inside

.github/workflows/podman_container_copy.yml Outdated Show resolved Hide resolved
plugins/modules/podman_container_copy.py Outdated Show resolved Hide resolved
plugins/modules/podman_container_copy.py Outdated Show resolved Hide resolved
.github/workflows/podman_container_copy.yml Outdated Show resolved Hide resolved
Signed-off-by: kubealex <al.rossi87@gmail.com>
@kubealex kubealex requested a review from sshnaidm August 13, 2024 09:47
Copy link
Member

@sshnaidm sshnaidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for this module!

@sshnaidm sshnaidm merged commit eb46429 into containers:master Aug 13, 2024
8 checks passed
@kubealex
Copy link
Contributor Author

Thank you @sshnaidm :)

@sshnaidm sshnaidm mentioned this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants