Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Improve get_ci_vm container docs #362

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

cevich
Copy link
Member

@cevich cevich commented Jun 24, 2024

The readme contained a lot of technical/implementation details, but lacked an overview of the architecture/operations. Fix this.

The readme contained a lot of technical/implementation details, but
lacked an overview of the architecture/operations.  Fix this.

Signed-off-by: Chris Evich <cevich@redhat.com>
@cevich cevich marked this pull request as ready for review June 24, 2024 15:17
Copy link
Member

@edsantiago edsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a couple of readings to get it sorted out, but that's because this is tricky. LGTM, thank you.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I haven't actually taken the time to fully understand this.

@cevich
Copy link
Member Author

cevich commented Jun 24, 2024

Thanks for taking a read-through guys. Hopefully this is never needed but if it is, exposing the magic could save someone a bunch of time trying to figure it out on their own.

@cevich cevich merged commit 014b518 into containers:main Jun 24, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants