-
Notifications
You must be signed in to change notification settings - Fork 75
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
cli: Add a new
bootc image
subcommand
We have a basic `bootc image list` but more interesting is `bootc image push` which defaults to copying the booted image into the container storage. Signed-off-by: Colin Walters <walters@verbum.org>
- Loading branch information
Showing
6 changed files
with
171 additions
and
3 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
//! # Controlling bootc-managed images | ||
//! | ||
//! APIs for operating on container images in the bootc storage. | ||
|
||
use anyhow::{Context, Result}; | ||
use fn_error_context::context; | ||
use ostree_ext::container::{ImageReference, Transport}; | ||
|
||
/// The name of the image we push to containers-storage if nothing is specified. | ||
const IMAGE_DEFAULT: &str = "localhost/bootc"; | ||
|
||
#[context("Listing images")] | ||
pub(crate) async fn list_entrypoint() -> Result<()> { | ||
let sysroot = crate::cli::get_locked_sysroot().await?; | ||
let repo = &sysroot.repo(); | ||
|
||
let images = ostree_ext::container::store::list_images(repo).context("Querying images")?; | ||
|
||
for image in images { | ||
println!("{image}"); | ||
} | ||
Ok(()) | ||
} | ||
|
||
#[context("Pushing image")] | ||
pub(crate) async fn push_entrypoint( | ||
transport: Transport, | ||
source: Option<&str>, | ||
target: Option<&str>, | ||
) -> Result<()> { | ||
let sysroot = crate::cli::get_locked_sysroot().await?; | ||
|
||
let repo = &sysroot.repo(); | ||
|
||
// If the target isn't specified, push to containers-storage + our default image | ||
let target = if let Some(target) = target { | ||
ImageReference { | ||
transport, | ||
name: target.to_owned(), | ||
} | ||
} else { | ||
ImageReference { | ||
transport: Transport::ContainerStorage, | ||
name: IMAGE_DEFAULT.to_string(), | ||
} | ||
}; | ||
|
||
// If the source isn't specified, we use the booted image | ||
let source = if let Some(source) = source { | ||
ImageReference::try_from(source).context("Parsing source image")? | ||
} else { | ||
let status = crate::status::get_status_require_booted(&sysroot)?; | ||
// SAFETY: We know it's booted | ||
let booted = status.2.status.booted.unwrap(); | ||
let booted_image = booted.image.unwrap().image; | ||
ImageReference { | ||
transport: Transport::try_from(booted_image.transport.as_str()).unwrap(), | ||
name: booted_image.image, | ||
} | ||
}; | ||
let mut opts = ostree_ext::container::store::ExportToOCIOpts::default(); | ||
opts.progress_to_stdout = true; | ||
println!("Copying local image {source} to {target} ..."); | ||
let r = ostree_ext::container::store::export(repo, &source, &target, Some(opts)).await?; | ||
|
||
println!("Pushed: {target} {r}"); | ||
Ok(()) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
# This test does: | ||
# bootc image push | ||
# podman build <from that image> | ||
# bootc switch <to the local image> | ||
use std assert | ||
use tap.nu | ||
|
||
# This code runs on *each* boot. | ||
# Here we just capture information. | ||
bootc status | ||
let st = bootc status --json | from json | ||
let booted = $st.status.booted.image.image | ||
|
||
# Run on the first boot | ||
def initial_build [] { | ||
tap begin "local image push + pull + upgrade" | ||
|
||
let td = mktemp -d | ||
cd $td | ||
|
||
do --ignore-errors { podman image rm localhost/bootc o+e>| ignore } | ||
bootc image push | ||
let img = podman image inspect localhost/bootc | from json | ||
|
||
# A simple derived container | ||
"FROM localhost/bootc | ||
RUN echo test content > /usr/share/blah.txt | ||
" | save Dockerfile | ||
# Build it | ||
podman build -t localhost/bootc-derived . | ||
# Just sanity check it | ||
let v = podman run --rm localhost/bootc-derived cat /usr/share/blah.txt | str trim | ||
assert equal $v "test content" | ||
# Now, fetch it back into the bootc storage! | ||
bootc switch --transport containers-storage localhost/bootc-derived | ||
# And reboot into it | ||
tmt-reboot | ||
} | ||
|
||
# The second boot; verify we're in the derived image | ||
def second_boot [] { | ||
assert equal $booted.transport containers-storage | ||
assert equal $booted.image localhost/bootc-derived | ||
let t = open /usr/share/blah.txt | str trim | ||
assert equal $t "test content" | ||
tap ok | ||
} | ||
|
||
def main [] { | ||
# See https://tmt.readthedocs.io/en/stable/stories/features.html#reboot-during-test | ||
match $env.TMT_REBOOT_COUNT? { | ||
null | "0" => initial_build, | ||
"1" => second_boot, | ||
$o => { error make {msg: $"Invalid TMT_REBOOT_COUNT ($o)" } }, | ||
} | ||
} |