Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically handle broken /etc/hostname and /etc/resolv.conf #1064

Closed
cgwalters opened this issue Jan 27, 2025 · 2 comments · Fixed by #1096
Closed

Automatically handle broken /etc/hostname and /etc/resolv.conf #1064

cgwalters opened this issue Jan 27, 2025 · 2 comments · Fixed by #1096
Labels
area/client Related to the client/CLI enhancement New feature or request

Comments

@cgwalters
Copy link
Collaborator

cgwalters commented Jan 27, 2025 •
edited
Loading

See containers/buildah#4242 (comment) and https://gitlab.com/fedora/bootc/tracker/-/issues/25

I think we can safely change bootc to just work around these on import time. The downside is we create drift between the container rootfs and what is visible at runtime, but I think it's worth it for this.
@cgwalters cgwalters added area/client Related to the client/CLI enhancement New feature or request labels Jan 27, 2025
@allisonkarlitskaya
Copy link
Contributor

This is interesting.

I accidentally worked around this in the composefs-rs examples by including extra/etc/resolv.conf -> ../run/systemd/resolve/stub-resolv.conf in a directory that gets added to the container via COPY. This produces a correct image, so we need to be careful: we shouldn't just blanket delete these files.

@Dianne087

This comment has been minimized.

Sign in to view
cgwalters added a commit to cgwalters/bootc that referenced this issue Feb 7, 2025
@cgwalters
store: Clean up broken /etc/hostname and /etc/resolv.conf
57bd0dc 
We can pretty safely work around this here; zero sized
files for both are useless.

Closes: containers#1064
Signed-off-by: Colin Walters <walters@verbum.org>
@cgwalters cgwalters mentioned this issue Feb 7, 2025
Merged
@ggiguash ggiguash mentioned this issue Feb 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/client Related to the client/CLI enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

store: Clean up broken /etc/hostname and /etc/resolv.conf cgwalters/bootc
3 participants
@cgwalters @allisonkarlitskaya @Dianne087