-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requires -v /dev:/dev
for reliable loopback
#352
Comments
This isn't a race at all, it's simply that by default that docker from the very start has created a static snapshot of |
Indeed, we ran into a similar issue in bib - we did osbuild/osbuild#1468 to fix it, i.e. if we know what loop device we need and it's not available in the container we just create the device node. |
-v /dev:/dev
for reliable loopback
Not a race condition, but more of a timing issue. Just needed to make sure the /dev mount was happening before any of the losetup calls. Fixes containers#352 Signed-off-by: Brad P. Crochet <brad@redhat.com> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
Not a race condition, but more of a timing issue. Just needed to make sure the /dev mount was happening before any of the losetup calls. Fixes containers#352 Signed-off-by: Brad P. Crochet <brad@redhat.com> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
At container start, /dev is snapshotted, so any new device files don't get added unless /dev is bindmounted in. For now, check that /dev is the same as the host's /dev via fsid. If they differ, it means that /dev is not bindmounted. Fixes containers#352 Signed-off-by: Brad P. Crochet <brad@redhat.com>
At container start, /dev is snapshotted, so any new device files don't get added unless /dev is bindmounted in. For now, check that /dev is the same as the host's /dev via fsid. If they differ, it means that /dev is not bindmounted. Fixes containers#352 Signed-off-by: Brad P. Crochet <brad@redhat.com>
At container start, /dev is snapshotted, so any new device files don't get added unless /dev is bindmounted in. For now, check that /dev is the same as the host's /dev via fsid. If they differ, it means that /dev is not bindmounted. Fixes containers#352 Signed-off-by: Brad P. Crochet <brad@redhat.com>
Something may have changed recently that this is now required. Have been building images using a similar technique with loopback mounts, all of a sudden https://gitlab.com/CentOS/automotive/sample-images/-/merge_requests/481 Note ublue hit something similar recently also: The lorax pointed out showed a possible alternate technique that could be use in containers also, the osbuild scripts could do something like this maybe:
but maybe this is bikeshed since -v /dev:/dev works |
This fixes containers/bootc#352
Sometimes I see:
I think we may need to wait on udev on the host.
The text was updated successfully, but these errors were encountered: