-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mdbook-linkcheck to CI #521
Comments
Fixes containers#521 Signed-off-by: John Eckersberg <jeckersb@redhat.com>
Fixes containers#521 Signed-off-by: John Eckersberg <jeckersb@redhat.com>
Fixes containers#521 Signed-off-by: John Eckersberg <jeckersb@redhat.com>
Fixes containers#521 Signed-off-by: John Eckersberg <jeckersb@redhat.com>
OK I had to revert this as it broke the site. I only dug in a bit but I think the problem is that the We could probably just remove it. Or, maybe we don't need to run link check on the main build? Needs some investigation and testing. |
Fixes containers#521 Signed-off-by: John Eckersberg <jeckersb@redhat.com>
Of course I just read this after I wrote https://github.com/containers/bootc/pull/533#issuecomment-2112971710#533 So yes, that's the problem. We might as well run linkcheck again on the main build, but we just need to upload the artifacts correctly with the right path. |
https://github.com/Michael-F-Bryan/mdbook-linkcheck
I've been catching these manually[1], but unsurprisingly computers are better at parsing things than my fallible biological parser.
[1] https://github.com/containers/bootc/pull/520/files/615ead5c9cc85066ef07af1da5321d1c112acc4f#diff-e0b4a488eccbd4e71db5387b0916834520b83da8da89b17f1842760ffd5e1963
The text was updated successfully, but these errors were encountered: