Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootc install: kargs defined in bootc install config not picked up #570

Closed
karelvanhecke opened this issue May 29, 2024 · 0 comments · Fixed by #606
Closed

bootc install: kargs defined in bootc install config not picked up #570

karelvanhecke opened this issue May 29, 2024 · 0 comments · Fixed by #606
Labels
area/install Issues related to `bootc install`

Comments

@karelvanhecke
Copy link

karelvanhecke commented May 29, 2024 •
edited
Loading

bootc version: 0.1.9-3.el9_4 (x86_64)

config:

[install.filesystem.root]
type = "xfs"
[install]
kargs = ["console=tty0", "console=ttyS0,115200n8"]

The kernel args defined in the config file are not applied during bootc install to-filesystem.
When passed through arguments --karg=console=tty0 --karg=console=ttyS0,115200n8, they are properly applied.
@cgwalters cgwalters added the area/install Issues related to `bootc install` label May 29, 2024
cgwalters added a commit to cgwalters/bootc that referenced this issue Jun 16, 2024
@cgwalters
install: Fix install config kargs + to-filesystem
836cdd8 
I think this got broken in a refactoring; add
test coverage.  In general all the heavy
lifting should move out of `baseline.rs`; a
good way to do that is probably to take the
next step of making it its own crate that
doesn't depend on the bootc core logic perhaps.

Closes: containers#570
Signed-off-by: Colin Walters <walters@verbum.org>
@cgwalters cgwalters mentioned this issue Jun 16, 2024
Merged
@travier travier mentioned this issue Jun 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/install Issues related to `bootc install`
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

install: Fix install config kargs + to-filesystem cgwalters/bootc
2 participants
@cgwalters @karelvanhecke