-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
async fn wipe_ostree
shouldn't block the thread
#778
Comments
omertuc
added a commit
to omertuc/bootc
that referenced
this issue
Sep 6, 2024
Solves containers#778 Signed-off-by: Omer Tuchfeld <omer@tuchfeld.dev>
omertuc
added a commit
to omertuc/bootc
that referenced
this issue
Sep 6, 2024
Solves containers#778 Signed-off-by: Omer Tuchfeld <omer@tuchfeld.dev>
omertuc
added a commit
to omertuc/bootc
that referenced
this issue
Sep 6, 2024
An async fn shouldn't block the thread, but write_deployments is a blocking heavy filesystem operation. Using tokio::task::spawn_blocking to avoid blocking async threads. Solves containers#778 Signed-off-by: Omer Tuchfeld <omer@tuchfeld.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
An
async fn
shouldn't block the thread, butwrite_deployments
is a totally blocking heavy filesystem operation. What we do in a few places is do heavy stuff like this inside atokio::task::spawn_blocking
.Originally posted by @cgwalters in #777 (comment)
The text was updated successfully, but these errors were encountered: