install: Rename install
-> install to-disk
, peer with to-filesystem
#226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install: Rename
install
->install to-disk
, peer withto-filesystem
Take the current
install
verb and change it to bebootc install to-disk
, and theninstall-to-filesystem
becomesbootc install to-filesystem
- they are obvious peers.The main motivation here is that in the end many use cases will
want nontrivial filesystem customization, and while I like having
a fully opinionated builtin flow to write to a target disk,
we should really think of
to-filesystem
as a fully equal peerof
to-disk
.Signed-off-by: Colin Walters walters@verbum.org
install-to-disk: Verify target is a block device
I saw someone get confused and think
bootc install
could workon a filesystem.
Signed-off-by: Colin Walters walters@verbum.org
install-to-filesystem: Verify target is a dir+mountpoint
Similarly to previous patch for
install to-disk
, verifythat the target is a directory and that it's a mountpoint (we
can't sanely support installing to a subdirectory of a filesystem).
Signed-off-by: Colin Walters walters@verbum.org