cli: Make sysroot lock automatically check root + setup mountns #619
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this change, we were always pairing together two functions:
prepare_for_write()
get_locked_sysroot()
Make the latter automatically call the former (and make it private to the cli code).
This will avoid bugs like dcfc752 where we forgot to call the first one and didn't end up with an unshared mountns.
While we're here, drop an unnecessary
async
from these functions, and just in case makeprepare_for_write()
idempotent.