Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes intended; just prep for further work.
kargs: parser cleanups
clone
it
pub
to parse
Signed-off-by: Colin Walters walters@verbum.org
kargs: Add a few more unit tests
Signed-off-by: Colin Walters walters@verbum.org
kargs: Parse booted kargs via cap-std, not liboverdrop
liboverdrop isn't helpful here because I don't think we want
or need right now to actually support things like having a file
in
/etc
or/run
override the kargs. Especially for/run
there's no dynamic runtime state.
No functional changes intended, just prep for more work.
It might in theory be useful for someone to have
/etc
overrides, but since we weren't actually doing that today, don't
pretend we might by using liboverdrop but not passing
/etc
toit.
Using cap-std here makes it easier to unit test safely.
(Although, liboverdrop really should grow an optional feature
to use cap-std)
Signed-off-by: Colin Walters walters@verbum.org
kargs: Drop unnecessary cloning for sys_arch
Since the function accepts a
&str
, drop the unnecessary cloning.Signed-off-by: Colin Walters walters@verbum.org
kargs: Drop unnecessary
mut
By passing ownership of the vector here we don't need to make
it
mut
able.Signed-off-by: Colin Walters walters@verbum.org
kargs: Drop unnecessary allocation and
mut
We can just pass the iterator directly to
extend
.Signed-off-by: Colin Walters walters@verbum.org
kargs: Minor code reordering
No functional changes, but it's clearer to have the
remote_kargs
definition below where we do the short-circuit.
Signed-off-by: Colin Walters walters@verbum.org