Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: Add a little CommandRunExt helper trait #733

Merged
merged 1 commit into from
Jul 26, 2024

Commits on Jul 25, 2024

  1. utils: Add a little CommandRunExt helper trait

    When I added the `Task` stuff it wasn't with the idea
    that we'd use it for *all* subprocess invocations.
    
    I think in some cases we really just do want a `Command` instance
    without the extra wrappering.
    
    Add an implementation (there are many of variants of this out
    there in lots of Rust codebases)
    
    This makes sense to use instead of `Task` where we're using
    `.quiet()` so that we don't print the description, and especially
    where we don't expect the task to fail usually, so it's OK
    if the error message is odd.
    
    Signed-off-by: Colin Walters <walters@verbum.org>
    cgwalters committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    858d886 View commit details
    Browse the repository at this point in the history