Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few misc cleanups #746

Merged
merged 7 commits into from
Aug 1, 2024
Merged

A few misc cleanups #746

merged 7 commits into from
Aug 1, 2024

Commits on Jul 31, 2024

  1. blockdev: Drop dead code 

    We have no use for listing all devices, so drop it.

Signed-off-by: Colin Walters <walters@verbum.org>
    @cgwalters
    cgwalters committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    1464acb View commit details
    Browse the repository at this point in the history

  2. blockdev: Fold listing fn 

    We only have a case for listing one device.

Signed-off-by: Colin Walters <walters@verbum.org>
    @cgwalters
    cgwalters committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    691910d View commit details
    Browse the repository at this point in the history

  3. lib: Move Command extensions to new mod cmdutil 

    Prep for more stuff there.

Signed-off-by: Colin Walters <walters@verbum.org>
    @cgwalters
    cgwalters committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    4ac9079 View commit details
    Browse the repository at this point in the history

  4. cmdutils: Add helper to run and parse JSON 

    It's handy to have a central helper for this.

Signed-off-by: Colin Walters <walters@verbum.org>
    @cgwalters
    cgwalters committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    3d22411 View commit details
    Browse the repository at this point in the history

  5. blockdev: Use JSON parsing helper 

    It's shorter and clearer and we get stderr.

Signed-off-by: Colin Walters <walters@verbum.org>
    @cgwalters
    cgwalters committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    3e89f8a View commit details
    Browse the repository at this point in the history

  6. Switch a few Task users to direct Command 

    I never intended the `Task` abstraction to be "the one way to
run subprocesses in bootc"...let's stop using it where:

- We're using `.quiet()` by default so we're not printing the
  description anyways, which is the *main* thing Task does
- We want to parse JSON, where we have a nice new helper

Signed-off-by: Colin Walters <walters@verbum.org>
    @cgwalters
    cgwalters committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    89aacb7 View commit details
    Browse the repository at this point in the history

  7. Fix two minor clippy lints 

    Signed-off-by: Colin Walters <walters@verbum.org>
    @cgwalters
    cgwalters committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    ecf9363 View commit details
    Browse the repository at this point in the history